[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: volume_id: off by one error detecting FAT16 vs FAT32
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2019-03-15 8:58:19
Message-ID: CAK1hOcOdkUrnUcnmC9mSwTj6YR+KskyOGCy4J=i4a5Pwo8as8g () mail ! gmail ! com
[Download RAW message or body]

Applied, thanks!

On Thu, Mar 14, 2019 at 5:38 PM Thomas Frauendorfer
<thomas.frauendorfer@gmail.com> wrote:
>
> Hello,
>
> Busybox detects a FAT file system with 65524 clusters as FAT32 while
> it should handle it as FAT16. Because of that blkid cannot detect the
> uuid or label on a FAT with 65524 clusters.
>
> The attached patch fixes that mistake.
>
> The cluster count values are defined in:
> Microsoft Extensible Firmware Initiative
> FAT32 File System Specification
> FAT: General Overview of On-Disk Format
>
> I used version 1.03 from December 6,2000
>
> The cluster count values are defined in pages 14 and 15 of that specification.
>
> Most users will probably not encounter that bug because the
> specification also states that file system creation code should stay
> away at least 16 clusters from that cluster count to avoid bugs in
> incorrect FAT code.
>
> Kind regards,
> Thomas
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]