[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 2/2] wget: add support for retries in http requests
From:       Martin Lewis <martin.lewis.x84 () gmail ! com>
Date:       2018-12-12 15:37:39
Message-ID: CA+nwWBstnvuiY2ndyBs2pzqphAkf_6VznTbht5tQgP9t31n1Gg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello,

These patches add the -t (--tries) option to wget.
There was an issue that wget died on errors, so I had to change some
functions to return error so we are able to retry.
Also I had to replace the blocking functions (and the set_alarm) with time
outing functions (in first patch).
In order to imitate fgets(), and not reading char by char checking for
newline I had to buffer the read.
I've seen that many features can be turned off in config, but as I see it,
adding these #ifs would rather bloat the patch, while the default behaviour
without the flag should not change.
Also as for ftp retries don't work yet.
If you would like me to change anything in the patches I would gladly do
when I have some more time.

Martin

[Attachment #5 (text/html)]

<div dir="ltr"><div>Hello,</div><div><br></div><div>These patches add the -t \
(--tries) option to wget.</div><div>There was an issue that wget died on errors, so I \
had to change some functions to return error so we are able to retry.</div><div>Also \
I had to replace the blocking functions (and the set_alarm) with time outing \
functions (in first patch).</div><div>In order to imitate fgets(), and not reading \
char by char checking for newline I had to buffer the read.</div><div>I&#39;ve seen \
that many features can be turned off in config, but as I see it, adding these #ifs \
would rather bloat the patch, while the default behaviour without the flag should not \
change.</div><div>Also as for ftp retries don&#39;t work yet.<br></div><div>If you \
would like me to change anything in the patches I would gladly do when I have some \
more time.</div><div><br></div><div>Martin<br></div></div>



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]