[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: [git commit] bc: new applet, throws warning
From: Gavin Howard <gavin.d.howard () gmail ! com>
Date: 2018-12-07 15:01:17
Message-ID: CAF=dzRPv5dpzyvNmj_5xJduNeqo+apBGzMGCbedPrpS0y+D9iw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Sure, it's 10 times bigger, but it actually implements arbitrary-precision
math, implements all of the dc commands except 1, and (this is probably the
biggest thing) implements dc strings properly, including being able to
*execute* them, conditionally and unconditionally.
I personally feel like it's an apples-to-oranges comparison.
That said, if you want my code out of busybox, just let me know. That's
your prerogative, and I would be wrong to be upset.
Gavin Howard
On Fri, Dec 7, 2018, 01:12 Bernhard Reutner-Fischer <rep.dot.nop@gmail.com
wrote:
> On 6 December 2018 22:38:45 CET, Gavin Howard <gavin.d.howard@gmail.com>
> wrote:
> >On Thu, Dec 6, 2018 at 2:30 PM Michael Conrad <mconrad@intellitree.com>
> >wrote:
> >>
> >> On 12/6/2018 11:48 AM, Gavin Howard wrote:
> >>
> >> > you are going to have to make the bc not give good error messages
> >and/or not check for errors as thoroughly (a massive chunk of the
> >parser, which is the largest portion, is dedicated to error checking),
> >reduce the quality of the code, reduce the performance of the math
> >(though this would not remove much), or all of them combined.
> >>
> >> Just FYI, these are typical things people do for busybox applets ;-)
> >>
> >> I'm not a bc user, so I don't care either way; having the applet
> >seems better than not having it, and you seem to have thoroughly
> >completed a difficult project. …but I do think maybe you missed the
> >spirit of Busybox code.
> >
> >Fair enough, mostly, because I know the point of busybox, actually. I
>
> Don't get me wrong, but given your dc was 10 (!) times the size of our
> existing implementation I would be surprised if the bc written in the same
> style was as small as it should be.
>
> thanks,
>
[Attachment #5 (text/html)]
<div dir="auto">Sure, it's 10 times bigger, but it actually implements \
arbitrary-precision math, implements all of the dc commands except 1, and (this is \
probably the biggest thing) implements dc strings properly, including being able to \
*execute* them, conditionally and unconditionally.<div dir="auto"><br></div><div \
dir="auto">I personally feel like it's an apples-to-oranges comparison.</div><div \
dir="auto"><br></div><div dir="auto">That said, if you want my code out of busybox, \
just let me know. That's your prerogative, and I would be wrong to be \
upset.</div><div dir="auto"><br></div><div dir="auto">Gavin \
Howard</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 7, 2018, \
01:12 Bernhard Reutner-Fischer <<a \
href="mailto:rep.dot.nop@gmail.com">rep.dot.nop@gmail.com</a> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">On 6 December 2018 22:38:45 CET, \
Gavin Howard <<a href="mailto:gavin.d.howard@gmail.com" target="_blank" \
rel="noreferrer">gavin.d.howard@gmail.com</a>> wrote:<br> >On Thu, Dec 6, 2018 \
at 2:30 PM Michael Conrad <<a href="mailto:mconrad@intellitree.com" \
target="_blank" rel="noreferrer">mconrad@intellitree.com</a>><br> >wrote:<br>
>><br>
>> On 12/6/2018 11:48 AM, Gavin Howard wrote:<br>
>><br>
>> > you are going to have to make the bc not give good error messages<br>
>and/or not check for errors as thoroughly (a massive chunk of the<br>
>parser, which is the largest portion, is dedicated to error checking),<br>
>reduce the quality of the code, reduce the performance of the math<br>
>(though this would not remove much), or all of them combined.<br>
>><br>
>> Just FYI, these are typical things people do for busybox applets ;-)<br>
>><br>
>> I'm not a bc user, so I don't care either way; having the applet<br>
>seems better than not having it, and you seem to have thoroughly<br>
>completed a difficult project. …but I do think maybe you missed the<br>
>spirit of Busybox code.<br>
><br>
>Fair enough, mostly, because I know the point of busybox, actually. I<br>
<br>
Don't get me wrong, but given your dc was 10 (!) times the size of our \
existing implementation I would be surprised if the bc written in the same style \
was as small as it should be.<br> <br>
thanks,<br>
</blockquote></div>
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic