[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ifupdown: Support "source-directory" stanza
From:       Bernhard Reutner-Fischer <rep.dot.nop () gmail ! com>
Date:       2018-10-01 20:32:20
Message-ID: 070FD6DC-10A6-4712-BC07-488AD22CBCE8 () gmail ! com
[Download RAW message or body]

On 1 October 2018 17:06:42 CEST, Brandon Maier <brandon.maier@rockwellcollins.com> \
wrote:
> On Mon, Oct 1, 2018 at 3:04 AM, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
> ...
> > Shouldn't this use recursive_action?
> 
> I hadn't seen recursive_action() when I wrote this. Is there a set of
> flags that gets us the same behavior? It looks like recursive_action
> always recurses through sub-directories, but we only want to recurse
> through the first directory.

Use NULL diraction and parse_interfaces as file action call back. See other \
recursive_action users for inspiration.

TIA,
> 
> I see the concat_subpath_file() helper in that function, that would be
> a better way to format the filenames. I can spin a follow-on patch to
> switch to that.
> 
> Also, after some further review on our end, it was pointed out that
> ifupdown's source-directory silently ignores if the directory is
> missing[1]. So I can include a change to switch xopendir -> opendir()
> as well.
> 
> [1] https://salsa.debian.org/debian/ifupdown/blob/0.8.33/config.c#L543

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]