[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 1/1] tar: Increase robustness of file descriptor handling
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2018-08-04 19:06:43
Message-ID: CAK1hOcPhZ9-daY_6R6Nx6oECKjoPNFe8r_9GpjQgHm=jfeEriA () mail ! gmail ! com
[Download RAW message or body]

Indeed, let's use dup()

On Sat, Aug 4, 2018 at 7:56 PM, Tobias Schramm <tobleminer@gmail.com> wrote:
> Uh, good catch. I wasn't thinking straight.
>
> Can we be sure fd3 is not data.rd though? I think your version might
> trash data.rd.
> I think we should use dup(tar_fd) to get a free fd.
>
> Cheers.
> Tobias
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]