[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] testsuite: add test for regression in cat
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2018-04-29 12:06:34
Message-ID: CAK1hOcNiihJDs5=R8sp7CmeXv+mpVk4uoJ=5g7KoNXrP6PDJbg () mail ! gmail ! com
[Download RAW message or body]

Fixed in git, test added in the "new style".

On Fri, Apr 27, 2018 at 5:22 PM, Natanael Copa <ncopa@alpinelinux.org> wrote:
> Add a couple of tests for a regression introduced with commit 75e90b15
> (cat: fix "cat -An" ignoring -n; make numbering go througn all files)
> 
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
> 
> I don't have a fix for the regression yet but I was able to find the
> commit which introduces it and made a couple of tests for the testsuite.
> 
> The bug causes the testsuite for GNU patch to fail. It took me a while
> to figure out that it was a bug in busybox cat and not in GNU patch :)
> 
> testsuite/cat/cat-show-end-of-line             | 3 +++
> testsuite/cat/cat-show-non-printing-characters | 3 +++
> 2 files changed, 6 insertions(+)
> create mode 100644 testsuite/cat/cat-show-end-of-line
> create mode 100644 testsuite/cat/cat-show-non-printing-characters
> 
> diff --git a/testsuite/cat/cat-show-end-of-line \
> b/testsuite/cat/cat-show-end-of-line new file mode 100644
> index 000000000..46945d4d4
> --- /dev/null
> +++ b/testsuite/cat/cat-show-end-of-line
> @@ -0,0 +1,3 @@
> +echo foo | busybox cat -e > foo
> +echo 'foo$' > bar
> +cmp foo bar
> diff --git a/testsuite/cat/cat-show-non-printing-characters \
> b/testsuite/cat/cat-show-non-printing-characters new file mode 100644
> index 000000000..541a8bab8
> --- /dev/null
> +++ b/testsuite/cat/cat-show-non-printing-characters
> @@ -0,0 +1,3 @@
> +echo foo | busybox cat -v > foo
> +echo foo > bar
> +cmp foo bar
> --
> 2.17.0
> 
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]