[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: serioius resgression with cpio -p and symlinks in busybox 1.28.2
From:       Natanael Copa <ncopa () alpinelinux ! org>
Date:       2018-04-03 9:33:13
Message-ID: 20180403113313.2325d0a8 () ncopa-desktop ! copa ! dup ! pw
[Download RAW message or body]

On Sat, 31 Mar 2018 16:25:57 +0200
Denys Vlasenko <vda.linux@googlemail.com> wrote:

> I can release a 1.28.3 in a few days if you want. Do you?
> 
> Let's see what else would crop up during weekend.

I think releasing 1.28.3 would be a good idea.

I would also like to have the following commits backported:

  e2afae6303e871a31a061d03359cfcd5dd86c088 sed: prevent overflow of length from \
bb_get_chunk_from_file  2da9724b56169f00bd7fb6b9a11c9409a7620981 libbb: remove \
unnecessary variable in xmalloc_fgets

Those look like they are fixing a security vulnerability and I think a
CVE should be requested. Note that ifup/ifdown segfaults without the
second commit (libbb: remove unnecessary variable in xmalloc_fgets)

Would also be nice to have grep fixed:

  03fd7e06f854d385070a6fc9714f445727c359cd grep: fix echo "aa" | busybox grep -F -w \
"a" (should not match)

Thanks!

-nc

> 
> On Fri, Mar 30, 2018 at 1:29 PM, Natanael Copa <ncopa@alpinelinux.org> wrote:
> > Hi,
> > 
> > There is a serious regression in busybox 1.28.2 that breaks booting
> > alpine linux machines.
> > 
> > The problem comes from /bin/sh -> /bin/busybox symlink no longer getting copied \
> > with cpio -p. 
> > To reproduce:
> > 
> > $ mkdir -p 1/bin 2
> > $ ln -s /bin/busybox 1/bin/sh
> > $ (cd 1 && echo "/bin/sh" | cpio -vdmp ../2)
> > bin/sh
> > 1 blocks
> > $ find 2/
> > 2/
> > 2/bin
> > 
> > The /bin/sh symlink was silently ignored and this causes the
> > initramfs's #/bin/sh script fail at boot.
> > 
> > It was previously possible to work around it by setting
> > EXTRACT_UNSAFE_SYMLINKS=1 but this no longer works.
> > 
> > https://git.alpinelinux.org/cgit/aports/commit/main/mkinitfs?id=1b6a167de8ce02d69dc8a8c8f4638aefd27c0ebe
> >  
> > Downstream bug report:
> > https://bugs.alpinelinux.org/issues/8751
> > 
> > -nc
> > _______________________________________________
> > busybox mailing list
> > busybox@busybox.net
> > http://lists.busybox.net/mailman/listinfo/busybox  

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]