[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] cpio: fix regression with symlinks
From:       Harald van Dijk <harald () gigawatt ! nl>
Date:       2018-03-31 18:49:41
Message-ID: 21ba419e-753d-fdf6-4b0f-3279990708dd () gigawatt ! nl
[Download RAW message or body]

On 3/30/18 8:16 PM, Denys Vlasenko wrote:
> On Fri, Mar 30, 2018 at 2:17 PM, Natanael Copa <ncopa@alpinelinux.org> wrote:
>> Fix to make cpio create symlinks.
>>
>> This fixes a regression in cpio introduced with
>> a84db18fc71d09e801df0ebca048d82e90b32c6a (tar,unzip: postpone creation
>> of symlinks with "suspicious" targets).
> 
> Is it really a regression? When I go back to
> commit 0cf64c8b5d86d603903397bfce87dea5a862caec,
> I don't see any code in cpio which would create these symlinks.
> Looks like it was broken all along?

It's a regression introduced by b920a38d, fixed when bc9bbeb2 mostly 
reverts b920a38d, re-introduced when a84db18f mostly reverts b920a38d. 
0cf64c8b was between b920a38d and bc9bbeb2, so that's why you saw the 
bug in there too.

Cheers,
Harald van Dijk
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]