[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] Prevent arping from freezing when no packet is received
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2018-02-13 16:02:55
Message-ID: CAK1hOcMwEFjhOAZ79+gpZt1gQ-utyZB=NNddvpxKh9fpNJrvng () mail ! gmail ! com
[Download RAW message or body]

On Mon, Feb 12, 2018 at 3:23 PM, Ortmann, Michael
<m.ortmann@lxinstruments.com> wrote:
> I'm not sure. The last sigprocmask call restores the original signal mask of the \
> thread. It looks kind of pointless since the two blocked signals are unblocked by \
> the sigprocmask(SIG_UNBLOCK) call in the next loop iteration. 
> The comment added in the iputils code talks about signal mask inheritance. In my \
> case arping was called via system() from a boost io_service thread for which most \
> signals were blocked. At least the SIG_UNBLOCK before recvfrom makes sense in this \
> case.

Expect many other programs to get confused in such a case.

> Since I don't know the consequences of removing that last sigprocmask() call I \
> would let it stay like in the iputils arping at GitHub.

I deleted it since now it's superfluous.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]