[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] env: -u option fails due to typo
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2017-12-25 20:37:05
Message-ID: CAK1hOcNEJnifh-G=mzDfD5t_Qpy+5Lm8REcLcHODWbGbB-HOQA () mail ! gmail ! com
[Download RAW message or body]

On Thu, Dec 7, 2017 at 2:38 PM, Ron Yorston <rmy@pobox.com> wrote:
> The -u option is supposed to be allowed to appear multiple times; the
> option string supplied to getopt32long requires it to be followed by a
> nonnegative integer.
>
> Reported-by: Keith Maxwell <keith.maxwell@gmail.com>
> Signed-off-by: Ron Yorston <rmy@pobox.com>
> ---
>  coreutils/env.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/coreutils/env.c b/coreutils/env.c
> index 20453e871..0aebead1b 100644
> --- a/coreutils/env.c
> +++ b/coreutils/env.c
> @@ -54,7 +54,7 @@ int env_main(int argc UNUSED_PARAM, char **argv)
>         unsigned opts;
>         llist_t *unset_env = NULL;
>
> -       opts = getopt32long(argv, "+iu:+",
> +       opts = getopt32long(argv, "+iu:*",
>                         "ignore-environment\0" No_argument       "i"
>                         "unset\0"              Required_argument "u"
>                         , &unset_env
> --
> 2.14.3


Applied, thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]