[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ash/hush: implement -d DELIM option for `read`
From:       Johannes Schindelin <Johannes.Schindelin () gmx ! de>
Date:       2017-08-08 14:47:09
Message-ID: alpine.DEB.2.21.1.1708081646490.11175 () virtualbox
[Download RAW message or body]

Hi,

On Tue, 8 Aug 2017, Kang-Che Sung wrote:

> On Mon, Aug 7, 2017 at 6:18 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> > The POSIX standard only requires the `read` builtin to handle `-r`:
> > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html
> >
> > However, Bash introduced the option `-d <DELIM>` to override IFS for
> > just one invocation, and it is quite useful.
> >
> > It is also super easy to implement in BusyBox' ash, so let's do that.
> >
> > The motivation: This option is used by Git's test suite.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Can you wrap the change within a macro conditional like #if BASH_READ_D ?

I can! And I did! It made the patch a little less readable, though.

Ciao,
Johannes
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]