[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ash: special treatment for 'busybox' in standalone shell mode
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2017-07-28 23:03:20
Message-ID: CAK1hOcNc=kDXFVWZj52NqdYfPPxgONuEApdEz_mj6j6zcocdtg () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jul 28, 2017 at 8:50 PM, Ron Yorston <rmy@pobox.com> wrote:
> Denys Vlasenko wrote:
>>How about this instead?
>
> Looks good.  It's less intrusive, though introduces a bit more bloat.
> My approach also works even if BUSYBOX is disabled in the configuration,
> though that isn't a big advantage because busybox isn't very useful when
> it's disabled.

If it's disabled, user explicitly requested not to waste code/data size
on "busybox" (quasi-)applet.


> Building with SH_STANDALONE enabled and TAB_COMPLETION disabled fails
> with:
>
> libbb/appletlib.c:776:36: error: conflicting types for ‘busybox_main'

-//applet:IF_BUSYBOX(IF_FEATURE_SH_STANDALONE(APPLET(busybox,
BB_DIR_BIN, BB_SUID_MAYBE)))

+//applet:IF_BUSYBOX(IF_FEATURE_SH_STANDALONE(IF_FEATURE_TAB_COMPLETION(APPLET(busybox,
BB_DIR_BIN, BB_SUID_MAYBE))))

I committed this change to git.
Thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]