[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] unzip: fix regression on big-endian machines
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2017-07-27 13:39:35
Message-ID: CAK1hOcNSn6X+rpKc-waLtqF12Ha1yS6DKsVDiu4XqMgGFRBb-w () mail ! gmail ! com
[Download RAW message or body]

Applied, thanks!

On Tue, Jul 25, 2017 at 8:44 PM, Natanael Copa <ncopa@alpinelinux.org> wrote:
> This fixes a regression which was introduced with commit 2a0867a5
> ("unzip: optional support for bzip2 and lzma") and causes unzip to exit
> with error when extracting archives:
>
>   unzip: unsupported method 2048
>
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
>  archival/unzip.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/archival/unzip.c b/archival/unzip.c
> index bb39d954e..8ed9ae7d5 100644
> --- a/archival/unzip.c
> +++ b/archival/unzip.c
> @@ -114,6 +114,7 @@ typedef union {
>
>  #define FIX_ENDIANNESS_ZIP(zip) \
>  do { if (BB_BIG_ENDIAN) { \
> +       (zip).fmt.method        = SWAP_LE16((zip).fmt.method      ); \
>         (zip).fmt.crc32         = SWAP_LE32((zip).fmt.crc32       ); \
>         (zip).fmt.cmpsize       = SWAP_LE32((zip).fmt.cmpsize     ); \
>         (zip).fmt.ucmpsize      = SWAP_LE32((zip).fmt.ucmpsize    ); \
> --
> 2.13.2
>
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]