[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v2 1/2] ash: introduce ash_perror_msg_and_raise_error()
From:       Johannes Schindelin <Johannes.Schindelin () gmx ! de>
Date:       2017-07-25 10:39:57
Message-ID: alpine.DEB.2.21.1.1707251239290.4271 () virtualbox
[Download RAW message or body]

Hi Ron,

On Sun, 23 Jul 2017, Ron Yorston wrote:

> Johannes Schindelin wrote:
> >@@ -1263,6 +1263,8 @@ ash_vmsg(const char *msg, va_list ap)
> > 			fprintf(stderr, "line %d: ", startlinno);
> > 	}
> > 	vfprintf(stderr, msg, ap);
> >+	if (strerr)
> >+		vfprintf(stderr, ": ", strerr);
> > 	newline_and_flush(stderr);
> > }
> > 
> 
> I think that should be:
> 
> >+	if (strerr)
> >+		fprintf(stderr, ": %s", strerr);

Oops, you're right! Funny how GCC did not catch that error.

Thanks,
Johannes
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]