[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v2 1/2] copyfd: reinstate proper guard around munmap()
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2017-07-15 9:46:57
Message-ID: CAK1hOcOcYBeB6bgzHhtLt=O9C9XFdwCmVgTjyVxbJsBQG3WGnQ () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jul 14, 2017 at 10:25 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was
> introduced where a large stack was allocated via mmap()

No, it is not a stack allocated there. It's a buffer for copying.

> But 8d75d794e (libbb: use sendfile() to copy data between file
> descriptors, 2014-11-27) removed that guard around the munmap() call.
> That was most likely a mistake, as the corresponding mmap() call is
> *still* inside an equivalent #if ... #endif guard.
>
> Let's revert the mistaken change.

It was not a mistake.

Applied with edited description.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]