[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 2/3] inet_common: handle FEATURE_ETC_NETWORKS as a compile-time flag
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2017-07-14 18:19:05
Message-ID: CAK1hOcOyXchJbgk4DZ==YWdtbxv+pA477N_FA0hDJ+kFp6XdKQ () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> This flag is used in #if ... #endif guards elsewhere and there is no
> good reason to pretend that it is a runtime flag in just one case.
>
> This probably was an oversight in a61cb92f2 (make /etc/network parsing
> configurable. -200 bytes when off., 2007-06-19).

It wasn't an oversight.

> Besides, it fixes a compile problem on systems where the getnetbyaddr()
> function is not available and the /etc/networks feature is disabled.

However, this point makes sense. Applied, thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]