[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 2/3] ash: shellexec: rename variable
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2017-04-12 18:17:08
Message-ID: CAK1hOcNdq=JbgD_xP3aGYSBGZf48fDTRvVmwsrmuiEwSatu0YQ () mail ! gmail ! com
[Download RAW message or body]

On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen
<kaarle.ritvanen@datakunkku.fi> wrote:
> Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
> ---
>  shell/ash.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/shell/ash.c b/shell/ash.c
> index 983f7b1..58ae950 100644
> --- a/shell/ash.c
> +++ b/shell/ash.c
> @@ -7748,7 +7748,7 @@ static void shellexec(char **, const char *, int) NORETURN;
>  static void
>  shellexec(char **argv, const char *path, int idx)
>  {
> -       char *cmdname;
> +       char *cmdpath;

This would introduce gratuitous difference from dash source.
Let's not do that. dash often have patches worth backporting,
and every difference makes backporting harder.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]