[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    RE: [PATCH] modutils: remove special handling of uClibc
From:       Rahul Bedarkar <Rahul.Bedarkar () imgtec ! com>
Date:       2016-12-26 16:59:39
Message-ID: 90B0A5D74F9D1542B45328A4E51B57F0DB2D0900 () PUMAIL01 ! pu ! imgtec ! org
[Download RAW message or body]

Hi Waldemar,

> Commit 3a45b87ac36f (modutils: support finit_module syscall) introduced
> macro finit_module. But it is not defined for uClibc.
> 
> The compilation for busybox fails for MIPS targets.
> With uClibc, we get following build errors:
> 
>   modutils/lib.a(modutils.o): In function `bb_init_module':
>   modutils.c:(.text.bb_init_module+0x94): undefined reference to `finit_module'
>   modutils.c:(.text.bb_init_module+0xa0): undefined reference to `finit_module'
>
> We can just use syscall() without any need for the
> uClibc wrappers.
> 
> Newer versions of uClibc-ng (>1.0.20) will remove the
> module syscall wrappers.
> 
> Found via Buildroot autobuilders:
> http://autobuild.buildroot.net/results/556/55655daef23788fb3967f801ec8b79e9bed7122b/build-end.log
> 
> Reported-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  modutils/modutils.c | 5 -----
>  1 file changed, 5 deletions(-)

modutils/modprobe-small.c is using init_module/delete_module wrappers unconditionally.
I think we should be using syscall() there as well.

Thanks,
Rahul
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]