[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [RFC PATCH] modutils: fix build with uClibc
From:       Waldemar Brodkorb <wbx () openadk ! org>
Date:       2016-12-23 6:54:37
Message-ID: 20161223065437.GG2915 () waldemar-brodkorb ! de
[Download RAW message or body]

Hi Rahul,
Rahul Bedarkar wrote,

> Hi Waldemar,
> 
> On Wednesday 21 December 2016 02:37 PM, Waldemar Brodkorb wrote:
> >Hi Rahul,
> >Rahul Bedarkar wrote,
> >
> >init_module / delete_module is just a wrapper for the syscalls.
> >Wouldn't it be just better to remove the wrappers in uClibc-ng and
> >just use syscall(..) like for all others?
> >
> >Can you try something like this?
> >
> 
> I was also thinking to use syscall directly in all cases. But thought that
> it might be some reason, which I am missing, for uClibc to use wrapper
> instead of syscall.
> 
> Earlier, I thought that this build failure is affecting uClibc for all
> architectures but it is only failing for MIPS + uClibc. I did build
> busybox-1.26.0 for all available external toolchains from Buildroot and it
> is only failing for MIPS + uClibc. After taking closer look, syscall.h is
> getting included from dirent.h for MIPS only and dirent.h is included from
> libbb.h.
> 
> MIPS specific dirent.h (./libc/sysdeps/linux/mips/bits/dirent.h) includes
> syscall.h for checking __NR_getdents64. Can we workout that without
> syscall.h like other libc and depending on *_OFFSET64 ? Otherwise, I can try
> to use syscall directly in modutils.c unless I am missing anything.

Thanks for analyzing. I think we should do both.
I like to remove the wrappers init_module/delete_module and remove
the dependency to syscall.h in MIPS dirent.h

I am running some tests and then will push the changes before
the next release.

best regards
 Waldemar
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]