[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Potential regression with ash "pause()" commit
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2016-11-03 19:22:11
Message-ID: CAK1hOcPMDpvSJZthhT=Xr2O+VxAgsYY5B2gEioYqw1s7p235vg () mail ! gmail ! com
[Download RAW message or body]

On Tue, Nov 1, 2016 at 6:51 AM, Kang-Che Sung <explorer09@gmail.com> wrote:
> Hello.
>
> I want to mention that in this commit
> "ash: use pause(), not sigsuspend(), in wait builtin"
> 8f7b0248adca9a88351fd7f3dd208775242f3fe6
> there could be a regression.
>
> I recently read about Problems with pause() in glibc manual
> <https://www.gnu.org/software/libc/manual/html_node/Pause-Problems.html>
> and this is why they recommend against using pause(): The signal could
> arrive after the (!pending_sig) check but before the pause(), causing
> the pause() to miss the signal or hang there indefinitely.

Indeed! Thanks, fixed it in git.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]