[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ash: return exit status of nofork applets
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2016-10-23 23:18:45
Message-ID: CAK1hOcP5_j5xfYSs==Arxwx7ExsZW+jL-7w5ZWD3X2ZOdL01cg () mail ! gmail ! com
[Download RAW message or body]

Applied, thanks!

On Thu, Oct 20, 2016 at 1:24 PM, Ron Yorston <rmy@pobox.com> wrote:
> The commit 'ash: eval: Return status in eval functions' changed how
> exit status is handled in eval functions.  The case of nofork
> applets was missed, resulting in the incorrect status potentially
> being returned for nofork applets when FEATURE_SH_NOFORK is enabled.
>
> Signed-off-by: Ron Yorston <rmy@pobox.com>
> ---
>  shell/ash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/shell/ash.c b/shell/ash.c
> index 50f479d..c9d39b8 100644
> --- a/shell/ash.c
> +++ b/shell/ash.c
> @@ -9576,7 +9576,7 @@ evalcommand(union node *cmd, int flags)
>                 if (applet_no >= 0 && APPLET_IS_NOFORK(applet_no)) {
>                         listsetvar(varlist.list, VEXPORT|VSTACK);
>                         /* run <applet>_main() */
> -                       exitstatus = run_nofork_applet(applet_no, argv);
> +                       status = run_nofork_applet(applet_no, argv);
>                         break;
>                 }
>  #endif
> --
> 2.7.4
>
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]