[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    RE: [PATCH 0/1] Race in parallel make
From:       "Bystricky, Juro" <juro.bystricky () intel ! com>
Date:       2016-09-14 15:28:20
Message-ID: 6E51916E4A1F32428260031F4C7CD2B61188CD13 () ORSMSX112 ! amr ! corp ! intel ! com
[Download RAW message or body]

Hello Bernhard,
are you saying that you submitted a patch about 6 years ago that fixes
this issue (Busybox parallel make race)? 
If so, I don't mind to (stress) test it.

Thanks,
Juro

> -----Original Message-----
> From: Bernhard Reutner-Fischer [mailto:rep.dot.nop@gmail.com]
> Sent: Tuesday, September 13, 2016 4:12 PM
> To: Bystricky, Juro <juro.bystricky@intel.com>; busybox@busybox.net
> Cc: jurobystricky@hotmail.com
> Subject: Re: [PATCH 0/1] Race in parallel make
> 
> On September 12, 2016 11:37:40 PM GMT+02:00, Juro Bystricky
> <juro.bystricky@intel.com> wrote:
> >
> >In spite of some improvements regarding the race during parallel make
> >as discussed in
> >https://www.mail-archive.com/busybox@busybox.net/msg23244.html ,
> >busybox build is eventually broken even with Busybox GIT commits
> >addressing the problem:
> >0dddbc1a59795a77679d8c5ef48a2795cb470563 ("build system: always rewrite
> >NUM_APPLETS.h")
> >d8e61bbf13d0cf38d477255cfd5dc71c5d51d575 ("build system: different fix
> >for include/applet_tables.h/include/NUM_APPLETS.h")
> >
> >The error is consistently the same:
> >
> >libbb/appletlib.c:164:13: error: 'NUM_APPLETS' undeclared (first use in
> >this function)
> >  while (i < NUM_APPLETS) {
> >
> >The reason is the include file where NUM_APPLETS is defined is not yet
> >generated (or is being modified)
> >at the time libbb/appletlib.c is compiled.
> >The attached patch fixes the problem by assuring libb is compiled as
> >the last directory.
> 
> This is getting silly. I wrote a patch to move all this hack to make
> proper, IIRC. Back then there was some obscure opposition, again IIRC.
> Could be this one:
> http://lists.busybox.net/pipermail/busybox/2010-May/072555.html
> 
> thanks,
> >
> >
> >
> >Juro Bystricky (1):
> >  Makefile: prevent race making libbb
> >
> > Makefile | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> 

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]