[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: ip route add bug in 1.25.0
From:       Ron Yorston <rmy () pobox ! com>
Date:       2016-08-05 18:02:39
Message-ID: 57a4d4bf.bPjE7/30EPSRia+L%rmy () pobox ! com
[Download RAW message or body]

Timo Teras wrote:
>Sounds like it's assuming the structure was previously initialized
>to all zeroes, and it's intended as a micro optimization to avoid
>writing zeroes again if the constant is zero.

Yes, that makes sense.

>Should probably just delete all those. Properly optimizing compiler
>would handle that automatically.

Apparently not, it does save a few bytes.  req.r.rtm_scope has already
been initialised to a non-zero value, though, so that one should come
out.  I'll put together a patch.

Ron
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]