[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] scripts/trylink: use portable invocation of mktemp
From:       Andrew Oates <andrew () andrewoates ! com>
Date:       2016-07-12 12:41:30
Message-ID: CAAVLcG5hj2hMrU_NNpa2LqCotO1TW9Ft+aqaXUc-YuC39QZGxA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thanks!

On Tue, Jul 12, 2016 at 7:55 AM, Denys Vlasenko <vda.linux@googlemail.com>
wrote:

> On Mon, Jul 11, 2016 at 3:44 PM, Brad Kemp <brad@beechwoods.com> wrote:
> >
> > On Jul 10, 2016, at 8:33 PM, Andrew Oates <andrew@andrewoates.com>
> wrote:
> >
> > --tmpdir unfortunately doesn't work on OS X/BSD-style mktemp, but '-t'
> does.
> > So "mktemp -t tmp.XXXXXXXXXX" obeys TMPDIR on both Linux and OS X.  "-t"
> is
> > marked as deprecated in the Linux version's manpage, however --- not
> sure if
> > you consider that a problem.
> >
> > Alternatively, it could just run "mktemp tmp.XXXXXXXXXX", which creates
> the
> > temporary file in the current directory on both systems.  Not ideal, but
> > consistent (and maybe that's fine given how the script is used in the
> build
> > system?)
> >
> > The local directory may not be writeable
>
> Then link will fail anyway: linker writes resulting binary there.
>
> I committed a change with "mktemp tmp.XXXXXXXXXX"
>

[Attachment #5 (text/html)]

<div dir="ltr">Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On \
Tue, Jul 12, 2016 at 7:55 AM, Denys Vlasenko <span dir="ltr">&lt;<a \
href="mailto:vda.linux@googlemail.com" \
target="_blank">vda.linux@googlemail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On Mon, Jul 11, 2016 at 3:44 PM, Brad Kemp \
&lt;<a href="mailto:brad@beechwoods.com">brad@beechwoods.com</a>&gt; wrote:<br> \
&gt;<br> &gt; On Jul 10, 2016, at 8:33 PM, Andrew Oates &lt;<a \
href="mailto:andrew@andrewoates.com">andrew@andrewoates.com</a>&gt; wrote:<br> \
&gt;<br> &gt; --tmpdir unfortunately doesn&#39;t work on OS X/BSD-style mktemp, but \
&#39;-t&#39; does.<br> &gt; So &quot;mktemp -t tmp.XXXXXXXXXX&quot; obeys TMPDIR on \
both Linux and OS X.   &quot;-t&quot; is<br> &gt; marked as deprecated in the Linux \
version&#39;s manpage, however --- not sure if<br> &gt; you consider that a \
problem.<br> &gt;<br>
&gt; Alternatively, it could just run &quot;mktemp tmp.XXXXXXXXXX&quot;, which \
creates the<br> &gt; temporary file in the current directory on both systems.   Not \
ideal, but<br> &gt; consistent (and maybe that&#39;s fine given how the script is \
used in the build<br> &gt; system?)<br>
&gt;<br>
&gt; The local directory may not be writeable<br>
<br>
</span>Then link will fail anyway: linker writes resulting binary there.<br>
<br>
I committed a change with &quot;mktemp tmp.XXXXXXXXXX&quot;<br>
</blockquote></div><br></div>



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]