[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] devmem: support more than 4GB of physical memory on 32 bit systems
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2016-07-03 15:02:55
Message-ID: CAK1hOcNHoDm4zQSQjVezjUY7kHg=ddSRqkzKj+8DOnoxUr4j-A () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jun 30, 2016 at 1:24 PM, Robert Schiele <rschiele@gmail.com> wrote:
> Signed-off-by: Robert Schiele <rschiele@gmail.com>
> ---
>  miscutils/devmem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/miscutils/devmem.c b/miscutils/devmem.c
> index 786a21b..5515da5 100644
> --- a/miscutils/devmem.c
> +++ b/miscutils/devmem.c
> @@ -20,7 +20,7 @@ int devmem_main(int argc UNUSED_PARAM, char **argv)
>         void *map_base, *virt_addr;
>         uint64_t read_result;
>         uint64_t writeval = writeval; /* for compiler */
> -       off_t target;
> +       off64_t target;
>         unsigned page_size, mapped_size, offset_in_page;
>         int fd;
>         unsigned width = 8 * sizeof(int);
> @@ -72,12 +72,12 @@ int devmem_main(int argc UNUSED_PARAM, char **argv)
>                  * Must map two pages to make it possible: */
>                 mapped_size *= 2;
>         }
> -       map_base = mmap(NULL,
> +       map_base = mmap64(NULL,
>                         mapped_size,
>                         argv[3] ? (PROT_READ | PROT_WRITE) : PROT_READ,
>                         MAP_SHARED,
>                         fd,
> -                       target & ~(off_t)(page_size - 1));
> +                       target & ~(off64_t)(page_size - 1));
>         if (map_base == MAP_FAILED)
>                 bb_perror_msg_and_die("mmap");


Wouldn't it work without this path if you select CONFIG_LFS=y ?
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]