[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: [PATCH] bug 8926 - Arping dropping leading 0 from mac address
From: Vito_Mulè <mule.vito () gmail ! com>
Date: 2016-05-28 23:59:15
Message-ID: CAFy+01Nq7phRXX6AmrdNJCJNnB9EGbKwvGF67Ak=pmt2Uk4=8w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hello,
makes sense.
Thanks for explaining this.
Cheers
On 29 May 2016 at 00:57, John Schroeder <jschroed@gmail.com> wrote:
> Hi Vito,
>
> From what I understand, you need to add a "Signed-off-by" line to your
> patches if you want your name/email attached to your patch. Otherwise, the
> busybox devs will keep your patch anonymous since some people wish to
> remain so by default. You can look at some previously submitted patches to
> see how others did this.
>
> --John Schroeder
>
> Thanks.
> Not complaining but I would have expected to be quoted in the commit.
> Not a big deal, it was a small patch.
>
> Cheers
>
> On Thursday, 26 May 2016, Denys Vlasenko < <vda.linux@googlemail.com>
> vda.linux@googlemail.com> wrote:
>
>> Fixed in git, thanks!
>>
>> On Wed, May 25, 2016 at 5:24 PM, Vito Mulè <mule.vito@gmail.com> wrote:
>> > friendly ping
>> >
>> > ---------- Forwarded message ----------
>> > From: Vito Mulè <mule.vito@gmail.com>
>> > Date: 16 May 2016 at 18:16
>> > Subject: Fwd: bug 8926 - Arping dropping leading 0 from mac address
>> > To: busybox@busybox.net
>> >
>> >
>> > Hello,
>> > not sure if this is necessary since I've opened the bug already,
>> apologies
>> > in case it's not.
>> > Bug link: https://bugs.busybox.net/show_bug.cgi?id=8926
>> >
>> >
>> > Not sure if this is intende but busybox arping is not consistent with
>> arping
>> > on linux, printing MAC addressed.
>> >
>> >
>> > root@agent4:/home/vmule# arping 192.168.1.159
>> > ARPING 192.168.1.159
>> > 60 bytes from 08:00:27:86:47:9d (192.168.1.159): index=0 time=1.002 sec
>> >
>> > and this is busybox arping
>> > root@agent4:/home/vmule# busybox arping 192.168.1.159
>> > ARPING to 192.168.1.159 from 192.168.1.157 via eth0
>> > Unicast reply from 192.168.1.159 [8:0:27:86:47:9d] 0.314ms
>> >
>> > I wrote a small patch to fix it:
>> >
>> >
>> > diff --git a/networking/arping.c b/networking/arping.c
>> > index 6b0de4d..2b22451 100644
>> > --- a/networking/arping.c
>> > +++ b/networking/arping.c
>> > @@ -230,12 +230,15 @@ static void recv_pack(unsigned char *buf, int len,
>> > struct sockaddr_ll *FROM)
>> > }
>> > if (!(option_mask32 & QUIET)) {
>> > int s_printed = 0;
>> > + struct ether_addr* mac = (struct ether_addr *) p;
>> >
>> > - printf("%scast re%s from %s [%s]",
>> > + printf("%scast re%s from %s
>> [%02x:%02x:%02x:%02x:%02x:%02x]
>> > ",
>> > FROM->sll_pkttype == PACKET_HOST ? "Uni" :
>> "Broad",
>> > ah->ar_op == htons(ARPOP_REPLY) ? "ply" :
>> "quest",
>> > inet_ntoa(src_ip),
>> > - ether_ntoa((struct ether_addr *) p));
>> > + mac->ether_addr_octet[0],
>> mac->ether_addr_octet[1],
>> > + mac->ether_addr_octet[2],
>> mac->ether_addr_octet[3],
>> > + mac->ether_addr_octet[4],
>> mac->ether_addr_octet[5]);
>> > if (dst_ip.s_addr != src.s_addr) {
>> > printf("for %s ", inet_ntoa(dst_ip));
>> > s_printed = 1;
>> > @@ -243,8 +246,11 @@ static void recv_pack(unsigned char *buf, int len,
>> > struct sockaddr_ll *FROM)
>> > if (memcmp(p + ah->ar_hln + 4, me.sll_addr,
>> ah->ar_hln)) {
>> > if (!s_printed)
>> > printf("for ");
>> > - printf("[%s]",
>> > - ether_ntoa((struct ether_addr *) p +
>> > ah->ar_hln + 4));
>> > + struct ether_addr* mac2 = mac + ah->ar_hln + 4;
>> > + printf("[%02x:%02x:%02x:%02x:%02x:%02x]",
>> > + mac2->ether_addr_octet[0],
>> > mac2->ether_addr_octet[1],
>> > + mac2->ether_addr_octet[2],
>> > mac2->ether_addr_octet[3],
>> > + mac2->ether_addr_octet[4],
>> > mac2->ether_addr_octet[5]);
>> > }
>> >
>> > if (last) {
>> >
>> >
>> > Ideas?
>> >
>> >
>> > Cheers
>> >
>> >
>> >
>> >
>> > _______________________________________________
>> > busybox mailing list
>> > busybox@busybox.net
>> > http://lists.busybox.net/mailman/listinfo/busybox
>>
>
>
> _______________________________________________
> busybox mailing listbusybox@busybox.nethttp://lists.busybox.net/mailman/listinfo/busybox
>
>
>
[Attachment #5 (text/html)]
<div dir="ltr">Hello,<div>makes sense.</div><div>Thanks for explaining \
this.</div><div>Cheers</div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On 29 May 2016 at 00:57, John Schroeder <span dir="ltr"><<a \
href="mailto:jschroed@gmail.com" target="_blank">jschroed@gmail.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Hi Vito, <br>
<br>
From what I understand, you need to add a "Signed-off-by" line to
your patches if you want your name/email attached to your patch.
Otherwise, the busybox devs will keep your patch anonymous since
some people wish to remain so by default. You can look at some
previously submitted patches to see how others did this.<span \
class="HOEnZb"><font color="#888888"><br> </font></span></div><span \
class="HOEnZb"><font color="#888888"> <div><br>
--John Schroeder</div></font></span><div><div class="h5">
<blockquote type="cite">Thanks.
<div>Not complaining but I would have expected to be quoted in the
commit.</div>
<div>Not a big deal, it was a small patch.</div>
<div><br>
</div>
<div>Cheers<br>
<br>
On Thursday, 26 May 2016, Denys Vlasenko <<a \
href="mailto:vda.linux@googlemail.com" target="_blank"></a><a \
href="mailto:vda.linux@googlemail.com" \
target="_blank">vda.linux@googlemail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Fixed in git, thanks!<br>
<br>
On Wed, May 25, 2016 at 5:24 PM, Vito Mulè <<a></a><a \
href="mailto:mule.vito@gmail.com" target="_blank">mule.vito@gmail.com</a>> \
wrote:<br> > friendly ping<br>
><br>
> ---------- Forwarded message ----------<br>
> From: Vito Mulè <<a>mule.vito@gmail.com</a>><br>
> Date: 16 May 2016 at 18:16<br>
> Subject: Fwd: bug 8926 - Arping dropping leading 0 from
mac address<br>
> To: <a>busybox@busybox.net</a><br>
><br>
><br>
> Hello,<br>
> not sure if this is necessary since I've opened the bug
already, apologies<br>
> in case it's not.<br>
> Bug link: <a href="https://bugs.busybox.net/show_bug.cgi?id=8926" \
target="_blank">https://bugs.busybox.net/show_bug.cgi?id=8926</a><br> ><br>
><br>
> Not sure if this is intende but busybox arping is not
consistent with arping<br>
> on linux, printing MAC addressed.<br>
><br>
><br>
> root@agent4:/home/vmule# arping 192.168.1.159<br>
> ARPING 192.168.1.159<br>
> 60 bytes from 08:00:27:86:47:9d (192.168.1.159): index=0
time=1.002 sec<br>
><br>
> and this is busybox arping<br>
> root@agent4:/home/vmule# busybox arping 192.168.1.159<br>
> ARPING to 192.168.1.159 from 192.168.1.157 via eth0<br>
> Unicast reply from 192.168.1.159 [8:0:27:86:47:9d]
0.314ms<br>
><br>
> I wrote a small patch to fix it:<br>
><br>
><br>
> diff --git a/networking/arping.c b/networking/arping.c<br>
> index 6b0de4d..2b22451 100644<br>
> --- a/networking/arping.c<br>
> +++ b/networking/arping.c<br>
> @@ -230,12 +230,15 @@ static void recv_pack(unsigned char
*buf, int len,<br>
> struct sockaddr_ll *FROM)<br>
> }<br>
> if (!(option_mask32 & QUIET)) {<br>
> int s_printed = 0;<br>
> + struct ether_addr* mac = (struct
ether_addr *) p;<br>
><br>
> - printf("%scast re%s from %s \
[%s]",<br> > + printf("%scast re%s from %s
[%02x:%02x:%02x:%02x:%02x:%02x]<br>
> ",<br>
> FROM->sll_pkttype ==
PACKET_HOST ? "Uni" : "Broad",<br>
> ah->ar_op ==
htons(ARPOP_REPLY) ? "ply" : "quest",<br>
> inet_ntoa(src_ip),<br>
> - ether_ntoa((struct ether_addr *)
p));<br>
> + mac->ether_addr_octet[0],
mac->ether_addr_octet[1],<br>
> + mac->ether_addr_octet[2],
mac->ether_addr_octet[3],<br>
> + mac->ether_addr_octet[4],
mac->ether_addr_octet[5]);<br>
> if (dst_ip.s_addr != src.s_addr) {<br>
> printf("for %s ",
inet_ntoa(dst_ip));<br>
> s_printed = 1;<br>
> @@ -243,8 +246,11 @@ static void recv_pack(unsigned char
*buf, int len,<br>
> struct sockaddr_ll *FROM)<br>
> if (memcmp(p + ah->ar_hln + 4,
me.sll_addr, ah->ar_hln)) {<br>
> if (!s_printed)<br>
> printf("for \
");<br>
> - printf("[%s]",<br>
> - ether_ntoa((struct
ether_addr *) p +<br>
> ah->ar_hln + 4));<br>
> + struct ether_addr* mac2 = mac +
ah->ar_hln + 4;<br>
> +
printf("[%02x:%02x:%02x:%02x:%02x:%02x]",<br>
> +
mac2->ether_addr_octet[0],<br>
> mac2->ether_addr_octet[1],<br>
> +
mac2->ether_addr_octet[2],<br>
> mac2->ether_addr_octet[3],<br>
> +
mac2->ether_addr_octet[4],<br>
> mac2->ether_addr_octet[5]);<br>
> }<br>
><br>
> if (last) {<br>
><br>
><br>
> Ideas?<br>
><br>
><br>
> Cheers<br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> busybox mailing list<br>
> <a>busybox@busybox.net</a><br>
> <a href="http://lists.busybox.net/mailman/listinfo/busybox" \
target="_blank">http://lists.busybox.net/mailman/listinfo/busybox</a><br> \
</blockquote> </div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
busybox mailing list
<a href="mailto:busybox@busybox.net" target="_blank">busybox@busybox.net</a>
<a href="http://lists.busybox.net/mailman/listinfo/busybox" \
target="_blank">http://lists.busybox.net/mailman/listinfo/busybox</a></pre> \
</blockquote> <br>
</div></div></div>
</blockquote></div><br></div>
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic