[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] cp: add -u/--update and --remove-destination
From:       shen long <wdlkmpx () gmail ! com>
Date:       2016-05-22 4:05:52
Message-ID: CADm8ZdXXkjYStEJUETAsWtNNXZu1ODDj2_BP9OMC9JaD_N5XxQ () mail ! gmail ! com
[Download RAW message or body]

Oops instead of
  if (unlink(dest) < 0) {

should be
  if (remove_file(dest, FILEUTILS_FORCE) < 0) {

or something like that?

this should go before that line:

				if (flags & FILEUTILS_INTERACTIVE) {
					fprintf(stderr, "%s: overwrite '%s'? ", applet_name, dest);
					if (!bb_ask_confirmation())
						return 0; /* not allowed to overwrite */
				}

so I think that should be it, i can resubmit the patch with these
changes, i guess i rushed
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]