[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    =?UTF-8?Q?1=2E24=2Ex_Regression=3A=C2=A0Cannot_compile_with?= =?UTF-8?Q?_glibc=3C2=2E12=28MNT=5FDETA
From:       Lélio <busybox () lio ! re>
Date:       2015-11-10 19:24:26
Message-ID: 038D5B6C-478C-4ACE-B43B-5CC23752A5A1 () lio ! re
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello, 

glibc2.2+ is supported according to the FAQ, but the symbol MNT_DETACH is not defined \
in sys/mount.h in glibc<2.10 (this symbol is defined in the kernel (in fs.h) but has \
not been ported to glibc).

This prevents util-linux/umount.c from compiling. This regression has been introduced \
by the commit c919d561ad.

This is already worked around in init/bootchartd.c with a conditional include. In \
order to avoid redundant code, it might be better to fix this define in libbb.h. The \
attached patch fixes the issue.

Best, 
Lélio 


[Attachment #5 (text/html)]

Hello, <br>
<br>
glibc2.2+ is supported according to the FAQ, but the symbol MNT_DETACH is not defined \
in sys/mount.h in glibc&lt;2.10 (this symbol is defined in the kernel (in fs.h) but \
has not been ported to glibc).<br> <br>
This prevents util-linux/umount.c from compiling. This regression has been introduced \
by the commit c919d561ad.<br> <br>
This is already worked around in init/bootchartd.c with a conditional include. In \
order to avoid redundant code, it might be better to fix this define in libbb.h. The \
attached patch fixes the issue.<br> <br>
Best, <br>
Lélio <br>


["glibc-missing-defines-2.patch" (application/octet-stream)]

diff --git a/include/libbb.h b/include/libbb.h
index 82484f9..3650c7d 100644
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -172,6 +172,9 @@ int klogctl(int type, char *b, int len);
 # define BUFSIZ 4096
 #endif
 
+#ifndef MNT_DETACH
+# define MNT_DETACH 2
+#endif
 
 /* Busybox does not use threads, we can speed up stdio. */
 #ifdef HAVE_UNLOCKED_STDIO
diff --git a/init/bootchartd.c b/init/bootchartd.c
index c7388c9..906269d 100644
--- a/init/bootchartd.c
+++ b/init/bootchartd.c
@@ -55,9 +55,6 @@
 # ifndef MS_SILENT
 #  define MS_SILENT      (1 << 15)
 # endif
-# ifndef MNT_DETACH
-#  define MNT_DETACH 0x00000002
-# endif
 #endif
 
 #if !ENABLE_TAR && !ENABLE_WERROR


_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]