[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [PATCH 2/3] libbb: allow_blank argument for ask_and_check_password_extended()
From:       Kaarle Ritvanen <kaarle.ritvanen () datakunkku ! fi>
Date:       2015-11-05 14:27:35
Message-ID: 1446733656-20223-2-git-send-email-kaarle.ritvanen () datakunkku ! fi
[Download RAW message or body]

---
 include/libbb.h          | 2 +-
 libbb/correct_password.c | 6 +++---
 loginutils/sulogin.c     | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/libbb.h b/include/libbb.h
index e607b8f..4c43c72 100644
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -1356,7 +1356,7 @@ void setup_environment(const char *shell, int flags, const \
struct passwd *pw) FA  void nuke_str(char *str) FAST_FUNC;
 int check_securetty(const char *short_tty);
 int check_password(const struct passwd *pw, const char *plaintext) FAST_FUNC;
-int ask_and_check_password_extended(const struct passwd *pw, int timeout, const char \
*prompt) FAST_FUNC; +int ask_and_check_password_extended(const struct passwd *pw, int \
timeout, int allow_blank, const char *prompt) FAST_FUNC;  int \
ask_and_check_password(const struct passwd *pw) FAST_FUNC;  /* Returns a malloced \
string */  #if !ENABLE_USE_BB_CRYPT
diff --git a/libbb/correct_password.c b/libbb/correct_password.c
index 513c930..57cd2b8 100644
--- a/libbb/correct_password.c
+++ b/libbb/correct_password.c
@@ -96,7 +96,7 @@ int FAST_FUNC check_password(const struct passwd *pw, const char \
                *plaintext)
  * NULL pw means "just fake it for login with bad username"
  */
 int FAST_FUNC ask_and_check_password_extended(const struct passwd *pw,
-		int timeout, const char *prompt)
+		int timeout, int allow_blank, const char *prompt)
 {
 	IF_FEATURE_SHADOWPASSWDS(char buffer[SHADOW_BUFSIZE];)
 	char *plaintext;
@@ -105,7 +105,7 @@ int FAST_FUNC ask_and_check_password_extended(const struct passwd \
*pw,  
 	pw_pass = get_passwd(pw, buffer);
 	if (!pw_pass[0]) /* empty password field? */
-		return 1;
+		return allow_blank;
 
 	plaintext = bb_ask(STDIN_FILENO, timeout, prompt);
 	if (!plaintext) {
@@ -120,5 +120,5 @@ int FAST_FUNC ask_and_check_password_extended(const struct passwd \
*pw,  
 int FAST_FUNC ask_and_check_password(const struct passwd *pw)
 {
-	return ask_and_check_password_extended(pw, 0, "Password: ");
+	return ask_and_check_password_extended(pw, 0, 1, "Password: ");
 }
diff --git a/loginutils/sulogin.c b/loginutils/sulogin.c
index 19b1e30..16a83f4 100644
--- a/loginutils/sulogin.c
+++ b/loginutils/sulogin.c
@@ -65,7 +65,7 @@ int sulogin_main(int argc UNUSED_PARAM, char **argv)
 	while (1) {
 		int r;
 
-		r = ask_and_check_password_extended(pwd, timeout,
+		r = ask_and_check_password_extended(pwd, timeout, 1,
 			"Give root password for system maintenance\n"
 			"(or type Control-D for normal startup):"
 		);
-- 
2.1.0

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]