[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Memory leak in ash with script using "local" incorrectly
From:       Rafał Miłecki <zajec5 () gmail ! com>
Date:       2015-10-30 6:08:16
Message-ID: CACna6rz=nzRmqrYnkxsUA0i9gxRb1ay7wgV0-cUJdpo4Fn4Y_Q () mail ! gmail ! com
[Download RAW message or body]

On 29 October 2015 at 16:36, Ron Yorston <rmy@pobox.com> wrote:
> Bastian Bittorf wrote:
>>i just tested v1.24.1 on OpenWrt[1] and there is *no* leak.
>
> I think this is due to
>
>   <0a0acb5> 2015-04-18 [Denys Vlasenko] ash: fix handling of duplicate "local"
>
> which is included in 1.24 but not 1.23.  This patch detects if a local
> variable is being declared more than once.  If it's a duplicate it
> doesn't allocate any additional space.

Thanks for your testing Bastian and thanks for pointing this commit
Ron. Nice someone already caught this problem :)

-- 
Rafał
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic