[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] i2c-tools: code cleanup: remove unused parts of kernel UAPI
From:       Bartosz_Gołaszewski <bartekgola () gmail ! com>
Date:       2015-09-02 16:21:46
Message-ID: CAFdkumgv5aQNhszk5Bkm1_Tc2Tu3-3JjyVk7jux8ZvxvQ8WJbg () mail ! gmail ! com
[Download RAW message or body]

2015-09-01 12:14 GMT+02:00 Bartosz Golaszewski <bartekgola@gmail.com>:
> The implementation is more or less feature complete. Remove the parts of
> kernel UAPI copied from include/uapi/linux/i2c.h that aren't used.
>
> Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
> ---
>  miscutils/i2c_tools.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
> index 38d90ff..59718b6 100644
> --- a/miscutils/i2c_tools.c
> +++ b/miscutils/i2c_tools.c
> @@ -78,12 +78,8 @@
>  #define I2C_SLAVE      0x0703
>  /* Use this slave address, even if it is already in use by a driver. */
>  #define I2C_SLAVE_FORCE        0x0706
> -/* 0 for 7 bit addrs, != 0 for 10 bit. */
> -#define I2C_TENBIT     0x0704
>  /* Get the adapter functionality mask. */
>  #define I2C_FUNCS      0x0705
> -/* Combined R/W transfer (one STOP only). */
> -#define I2C_RDWR       0x0707
>  /* != 0 to use PEC with SMBus. */
>  #define I2C_PEC                0x0708
>  /* SMBus transfer. */
> @@ -97,12 +93,6 @@ struct i2c_smbus_ioctl_data {
>         union i2c_smbus_data *data;
>  };
>
> -/* Structure used in the I2C_RDWR ioctl call. */
> -struct i2c_rdwr_ioctl_data {
> -       struct i2c_msg *msgs;   /* Pointers to i2c_msgs. */
> -       uint32_t nmsgs;         /* Number of i2c_msgs. */
> -};
> -
>  /* As specified in SMBus standard. */
>  #define I2C_SMBUS_BLOCK_MAX            32
>  /* Not specified but we use same structure. */
> @@ -116,7 +106,6 @@ union i2c_smbus_data {
>         uint8_t block[I2C_SMBUS_BLOCK_MAX + 2];
>  };
>
> -#define I2C_RDRW_IOCTL_MAX_MSGS                42
>  #define I2C_MAX_REGS                   256
>
>  /* Smbus_access read or write markers. */
> @@ -140,8 +129,6 @@ union i2c_smbus_data {
>
>  /* Defines to determine what functionality is present. */
>  #define I2C_FUNC_I2C                           0x00000001
> -#define I2C_FUNC_10BIT_ADDR                    0x00000002
> -#define I2C_FUNC_PROTOCOL_MANGLING             0x00000004
>  #define I2C_FUNC_SMBUS_PEC                     0x00000008
>  #define I2C_FUNC_SMBUS_BLOCK_PROC_CALL         0x00008000
>  #define I2C_FUNC_SMBUS_QUICK                   0x00010000
> --
> 2.1.4
>

Superseded by:
http://lists.busybox.net/pipermail/busybox/2015-September/083348.html

-- 
Best regards,
Bartosz Golaszewski
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]