[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v2] i2cdetect: use break instead of goto in list_i2c_busses_and_exit()
From:       Bartosz_Gołaszewski <bartekgola () gmail ! com>
Date:       2015-06-08 11:49:02
Message-ID: CAFdkumjObGB-i8nN+NbtBrh2ATWjDfH9XJBx5bmVhDZ1t0_w8A () mail ! gmail ! com
[Download RAW message or body]

2015-06-07 18:08 GMT+02:00 Denys Vlasenko <vda.linux@googlemail.com>:
> Applied all five patches, thanks!
>
> On Fri, Jun 5, 2015 at 10:47 AM, Bartosz Golaszewski
> <bartekgola@gmail.com> wrote:
>> Since there are no more statements in the if block after the while loop
>> in list_i2c_busses_and_exit(), there's no need for a goto.
>>
>> Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
>> ---
>> NOTES: fixed two typos in the commit message.

Hi Denys,

you applied the previous version of patch [5/5] - the one with typos
in the commit message. I don't know what the busybox policy is on
force-pushing to mainline git, but saying 'there are now more
statements' instead of 'there are no more statements' can be
confusing. ;)

Best regards,
Bartosz Golaszewski
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]