[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ash: fix a regression in handling local variables
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2015-04-18 17:42:03
Message-ID: CAK1hOcO6B=6AQ55NBqkuaS8yvTxyabHJLZ0f_Ke8Hi02K2RTxw () mail ! gmail ! com
[Download RAW message or body]

On Fri, Apr 17, 2015 at 1:58 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> commit 109ee5d33694a03cda3424b4846584250832ba8e
> "ash: make "locak VAR" unset VAR (bash does that)"
>
> This commit introduced a regression where calling local on an already
> local variable unsets it. This does not match bash behavior.
>
> Update test case to check for this behavior

Since we need to check whether variable is local, it makes sense to
avoid creating a duplicate entry in "localvars" linked list too,
if we discover that it is, indeed, an already-local variable.

I committed a fix which does that.

Thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]