[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: Deluser: deleting the home folder
From: Laszlo Papp <lpapp () kde ! org>
Date: 2015-02-05 22:10:58
Message-ID: CAOMwXhMBb8mzHQuGyCbSg+FbPJ6q-cuejq1geXF-EfHOFabEoQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Thursday, February 5, 2015, Denys Vlasenko <vda.linux@googlemail.com>
wrote:
> On Thu, Feb 5, 2015 at 7:48 PM, Laszlo Papp <lpapp@kde.org> wrote:
>> On Thu, Feb 5, 2015 at 6:41 PM, Denys Vlasenko <vda.linux@googlemail.com>
wrote:
>>> On Thu, Feb 5, 2015 at 6:49 PM, Laszlo Papp <lpapp@kde.org> wrote:
>>>> I think it is bad idea to only allow this operation when long options
>>>> are enabled. Long options and this functionality are two separate
>>>> things in my book.
>>>
>>>
>>> "Standard" deluser has only long options.
>>>
>>> Incompatibility is not a good thing.
>>
>> Sure, but busybox has short option in other cases for such operation,
>> so you need incompatibility somewhere anyway.
>
> I think it was a mistake to add incompatible short options
> to applets whose "standard" versions had only long options.
>
>> In addition, the long option is not the problem. The problem is that
>> the functionality is switched off by switching the long option off,
>> rather than the actual functionality.
>
> It's about 6.5 kbytes of code in static build.
>
>> Therefore, busybox does not
>> remain as fine-tunable as possible.
>
> There are two extremes: not having any tuning knobs,
> and having a tuning know for every possible case.
> Both are bad. The latter one too - you will need to answer
> to thousands of questions in "make config".
>
> I tend to add new knobs (CONFIG_xyz) when somebody
> is pissed enough to complain about it.
>
> Do you want to add CONFIG_FEATURE_DELUSER_LONG_OPTIONS?
Yes, if you are also happy with that. Your patch otherwise is ok to me,
thanks for following this up and apologies if I had been pushy.
[Attachment #5 (text/html)]
<br><br>On Thursday, February 5, 2015, Denys Vlasenko <<a \
href="mailto:vda.linux@googlemail.com">vda.linux@googlemail.com</a>> \
wrote:<br>> On Thu, Feb 5, 2015 at 7:48 PM, Laszlo Papp <<a \
href="mailto:lpapp@kde.org">lpapp@kde.org</a>> wrote:<br>>> On Thu, Feb 5, \
2015 at 6:41 PM, Denys Vlasenko <<a \
href="mailto:vda.linux@googlemail.com">vda.linux@googlemail.com</a>> \
wrote:<br>>>> On Thu, Feb 5, 2015 at 6:49 PM, Laszlo Papp <<a \
href="mailto:lpapp@kde.org">lpapp@kde.org</a>> wrote:<br>>>>> I think \
it is bad idea to only allow this operation when long options<br>>>>> are \
enabled. Long options and this functionality are two separate<br>>>>> \
things in my book.<br>>>><br>>>><br>>>> \
"Standard" deluser has only long options.<br>>>><br>>>> \
Incompatibility is not a good thing.<br>>><br>>> Sure, but busybox has \
short option in other cases for such operation,<br>>> so you need \
incompatibility somewhere anyway.<br>><br>> I think it was a mistake to add \
incompatible short options<br>> to applets whose "standard" versions had \
only long options.<br>><br>>> In addition, the long option is not the \
problem. The problem is that<br>>> the functionality is switched off by \
switching the long option off,<br>>> rather than the actual \
functionality.<br>><br>> It's about 6.5 kbytes of code in static \
build.<br>><br>>> Therefore, busybox does not<br>>> remain as \
fine-tunable as possible.<br>><br>> There are two extremes: not having any \
tuning knobs,<br>> and having a tuning know for every possible case.<br>> Both \
are bad. The latter one too - you will need to answer<br>> to thousands of \
questions in "make config".<br>><br>> I tend to add new knobs \
(CONFIG_xyz) when somebody<br>> is pissed enough to complain about \
it.<br>><br>> Do you want to add \
CONFIG_FEATURE_DELUSER_LONG_OPTIONS?<br><br>Yes, if you are also happy with that. \
Your patch otherwise is ok to me, thanks for following this up and apologies if I had \
been pushy.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic