[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] ntpd: don't stay at short polling interval
From:       Miroslav Lichvar <mlichvar () redhat ! com>
Date:       2015-01-09 14:29:32
Message-ID: 20150109142932.GB26973 () localhost
[Download RAW message or body]

On Sun, Jan 04, 2015 at 06:12:41PM +0100, Denys Vlasenko wrote:
> > Great, thanks!
> >
> > The changes you have made to the patch seems to disable increasing the
> > polling interval when the -w option is used, was that intended?
> 
> Are you referring to this hunk being not applied?

I meant the following hunk and the other changes related to it.

        filter_datapoints(p);
        q = select_and_cluster();
-       rc = -1;
+       rc = 1;
        if (q) {
-               rc = 0;
                if (!(option_mask32 & OPT_w)) {
                        rc = update_local_clock(q);

In git there is now:

        filter_datapoints(p);
        q = select_and_cluster();
        rc = 0;
        if (q) {
                if (!(option_mask32 & OPT_w)) {
                        rc = update_local_clock(q);

which means with -w the polling interval will stay at the minimum
unless the selection fails and q is zero. I guess -w is mainly used
for debugging, so it's probably not a big deal, I'd just not expect it
to influence the poll control.

-- 
Miroslav Lichvar
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]