[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: 1.22.1: been hit by the zcat bug
From:       Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn () axis ! com>
Date:       2014-10-22 18:20:49
Message-ID: alpine.DEB.2.11.1410222004030.4987 () enwn ! fr ! nkvf ! pbz
[Download RAW message or body]

On Tue, 21 Oct 2014, Cristian Ionescu-Idbohrn wrote:
> On Tue, 21 Oct 2014, Mike Frysinger wrote:
> > On 21 Oct 2014 20:26, Cristian Ionescu-Idbohrn wrote:
> > > On Tue, 21 Oct 2014, Mike Frysinger wrote:
> > > > On 21 Oct 2014 20:02, Cristian Ionescu-Idbohrn wrote:
> > > > >
> > > > > Nothing needs to be fixed.  What I'm merryly suggesting is adding
> > > > > the appropriate _existing_ patch(es) to
> > > > > http://busybox.net/downloads/fixes-1.22.1/.  There may be a
> > > > > general intrest in that.
> > > >
> > > > yes, but the branches aren't just "let's cherry pick everything".
> > >
> > > I didn't suggest that.  I recall saying "appropriate".
> > >
> > > > they tend to be for specific bugs that users have noticed.  hence
> > > > i'm asking, what bugs are you seeing in the current release that you
> > > > want fixed *in the branch* ?  so far, you've shown one case, and
> > > > only (small) commit is needed for that.  if you have no other use
> > > > cases that are impacted, we'll just ignore the rest and move on.
> > >
> > > Whatever.  You decide.  I can do my own patching.
> >
> > ffs, i don't know why all this pointless dancing.  i guess the
> > answer is you only have the one use case, so only that one patch
> > needs to be cherry picked.  you aren't hitting any other issues, so
> > there's no need to waste time backporting other commits. -mike
>
> Please go ahead with whatever you think fit.

Thanks for downloads/fixes-1.22.1/busybox-1.22.1-zcat-no-ext.patch.

Unfortunately, commit 28dd64a0e1a9cffcde7799f2849b66c0e16bb9cc alone
didn't make it fly :(

	/bin/tar tvf foo.tar
	tar: no gzip magic

I ended up applying these commits:

From 28dd64a0e1a9cffcde7799f2849b66c0e16bb9cc
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Fri, 10 Jan 2014 14:06:57 +0100
Subject: libarchive: open_zipped() does not need to check extensions for e.g. gzip

From 7c47b560a8fc97956dd8132bd7f1863d83c19866
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Fri, 10 Jan 2014 14:06:57 +0100
Subject: libarchive: open_zipped() does not need to check

From 0f592d7fb94c5887528d0ee24020c2225ab71c28
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Fri, 10 Jan 2014 18:02:38 +0100
Subject: tar: tighten up pax header validity check

From b664f740d90880560ce46b11f766625341342e80
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Mon, 27 Jan 2014 13:02:18 +0100
Subject: libbb: open_zipped() should not fail on non-compressed files

From 640ce3de07807133796bccd0bdfa146bbfc788c7
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sun, 2 Feb 2014 02:06:38 +0100
Subject: zcat: complain if input is not compressed

From 640ce3de07807133796bccd0bdfa146bbfc788c7
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sun, 2 Feb 2014 02:06:38 +0100
Subject: zcat: complain if input is not compressed

Thank you Denys for the patches.

I left out:

	2108a6f0b56633fba1e70af406da147c02b11765
	81071e6872eeb9e47b938d5d6fd82056aaebdd2e
	a9dc7c2f59dc5e92870d2d46316ea5c1f14740e3

as they deal with unlzma and lzop, which I don't use.  If you can
think of a better solution I'm all ears ;)


Cheers,

-- 
Cristian
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]