[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 1/3] testsuite: warning when bash is not in use.
From:       Laszlo Papp <lpapp () kde ! org>
Date:       2014-08-19 6:27:31
Message-ID: CAOMwXhMn8TD7DHbJjTyTSgkwsyrvca6aG_9KXgKe4A7A6QeV8Q () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, Aug 19, 2014 at 7:24 AM, Natanael Copa <ncopa@alpinelinux.org>
wrote:

> On Mon, 18 Aug 2014 00:11:10 -0300
> Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com> wrote:
>
> > The test suite scripts fail with "Bad substitution" error when using a
> shell
> > other than Bash. This patch adds an alert to the user, to remind him to
> change
> > its /bin/sh symlink.
>
> Wouldn't it be better to do:
>

Or even eliminate the bashism?


> diff --git a/testsuite/runtest b/testsuite/runtest
> index 51575d9..35968b1 100755
> --- a/testsuite/runtest
> +++ b/testsuite/runtest
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>  # Usage:
>  # runtest [applet1] [applet2...]
>
>
> Or even better, fix the script to be posix compliant?
>

Yep, exactly... +1 to this.

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, \
Aug 19, 2014 at 7:24 AM, Natanael Copa <span dir="ltr">&lt;<a \
href="mailto:ncopa@alpinelinux.org" \
target="_blank">ncopa@alpinelinux.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div class="">On Mon, 18 Aug 2014 00:11:10 -0300<br> \
Guilherme Maciel Ferreira &lt;<a \
href="mailto:guilherme.maciel.ferreira@gmail.com">guilherme.maciel.ferreira@gmail.com</a>&gt; \
wrote:<br> <br>
&gt; The test suite scripts fail with &quot;Bad substitution&quot; error when using a \
shell<br> &gt; other than Bash. This patch adds an alert to the user, to remind him \
to change<br> &gt; its /bin/sh symlink.<br>
<br>
</div>Wouldn&#39;t it be better to do:<br></blockquote><div><br></div><div>Or even \
eliminate the bashism?<br></div><div>  </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

diff --git a/testsuite/runtest b/testsuite/runtest<br>
index 51575d9..35968b1 100755<br>
--- a/testsuite/runtest<br>
+++ b/testsuite/runtest<br>
@@ -1,4 +1,4 @@<br>
-#!/bin/sh<br>
+#!/bin/bash<br>
  # Usage:<br>
  # runtest [applet1] [applet2...]<br>
<br>
<br>
Or even better, fix the script to be posix compliant?<br><div class="HOEnZb"><div \
class="h5"></div></div></blockquote><div><br></div><div>Yep, exactly... +1 to \
this.<br></div></div></div></div>



_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]