[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] nanddump: dump rigth length when jumping bad blocks
From:       Richard Genoud <richard.genoud () gmail ! com>
Date:       2014-06-19 8:02:59
Message-ID: CACQ1gAh2wznpsvdAtkzVPTAufuF6_UVTNVGwnpQ3e1sba9sv3A () mail ! gmail ! com
[Download RAW message or body]

2014-06-18 21:53 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> Hi Richard,
>
> On Wed, Jun 18, 2014 at 04:59:49PM +0200, Richard Genoud wrote:
>> 2014-06-18 16:08 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
>> > On Wed, Jun 18, 2014 at 03:44:30PM +0200, Richard Genoud wrote:
>> >> With the "skip bad block" option, nanddump is not dumping the right
>> >> length if there's bad blocks.
>> >>
>> >> This patch moves the end read address each time a bad block is
>> >> encountered.
>> >
>> > This changes nanddump behaviour from upstream historical --omitbad (-b;
>> > removed in upstream d8b8f780ec3c), to existing skipbad, for which upstream
>> > uses the --bb=skipbad command line parameter. To avoid confusion, we should
>> > adapt to upstream command line parameter names, IMO.
>>
>> yeah, you are right, I verified with upstream nanddump, and it doesn't
>> update the length on bad block.
>> so, please ignore this patch.
>
> I'm have no objection to this change. It matches the change made in upstream
> mtd-utils code (commits 5dfb5a6adc7311 and d8b8f780ec3c916). I just think that
> we should also change the command line parameters name to match (from -b to
> --bb=skipbad; see mtd-utils commit c2c3cb928935c).

ok, I see.
I'll come back with a new patch matching mtd-utils' 1.5.1 nanddump
behaviour --bb=skipbad.

Thanks !
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]