[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Changing the user name
From:       Tito <farmatito () tiscali ! it>
Date:       2014-05-14 13:53:32
Message-ID: 201405141553.32502.farmatito () tiscali ! it
[Download RAW message or body]

On Wednesday 14 May 2014 15:10:12 you wrote:
> On Wed, May 14, 2014 at 1:38 PM, Tito <farmatito@tiscali.it> wrote:
> > On Wednesday 14 May 2014 12:33:45 you wrote:
> >> On Tue, May 13, 2014 at 8:27 PM, Tito <farmatito@tiscali.it> wrote:
> >> > On Tuesday 13 May 2014 19:01:41 Laszlo Papp wrote:
> >> >> Hi,
> >> >>
> >> >> is this possible? I am looking for something like "usermod -l" on desktop.
> >> >
> >> > This is actually not supported by busybox.
> >> > So far we are able to add and delete users or groups
> >> > or add users to groups or delete users from groups.
> >>
> >> Is that by design or no one has stepped up yet doing the work?
> >
> > I suppose nobody needed that feature so far.
> 
> OK, let us say I need this feature:
> 
> * Is it acceptable to add it to busybox (at least with some configuration)?
> 
> * Where would it fit, adduser, separate applet or somewhere else?
> 

Separate applet (usermod ?) with the options that could
not be done with the existing applets.

      usermod - modify a user account


( No)      -a, --append  -> adduser user group
           Add the user to the supplementary group(s). Use only with the -G option.

 (Don't know)      -c, --comment COMMENT
           The new value of the user's password file comment field. It is normally modified using
           the chfn(1) utility.

  (Yes if -l)     -d, --home HOME_DIR
           The user's new login directory.

           If the -m option is given, the contents of the current home directory will be moved to
           the new home directory, which is created if it does not already exist.

 (Don't know)       -e, --expiredate EXPIRE_DATE
           The date on which the user account will be disabled. The date is specified in the format
           YYYY-MM-DD.

           An empty EXPIRE_DATE argument will disable the expiration of the account.

           This option requires a /etc/shadow file. A /etc/shadow entry will be created if there
           were none.

          An empty EXPIRE_DATE argument will disable the expiration of the account.

           This option requires a /etc/shadow file. A /etc/shadow entry will be created if there
           were none.

(Don't know)         -f, --inactive INACTIVE
           The number of days after a password expires until the account is permanently disabled.

           A value of 0 disables the account as soon as the password has expired, and a value of -1
           disables the feature.

           This option requires a /etc/shadow file. A /etc/shadow entry will be created if there
           were none.

(Don't know, but bb's policy is to create a group with the same username name
and  problematic for existing file ownership) 
        -g, --gid GROUP
           The group name or number of the user's new initial login group. The group must exist.

           Any file from the user's home directory owned by the previous primary group of the user
           will be owned by this new group.
 	   The group ownership of files outside of the user's home directory must be fixed manually.

(No  -> adduser user group)      
       -G, --groups GROUP1[,GROUP2,...[,GROUPN]]]
           A list of supplementary groups which the user is also a member of. Each group is
           separated from the next by a comma, with no intervening whitespace. The groups are
           subject to the same restrictions as the group given with the -g option.

           If the user is currently a member of a group which is not listed, the user will be
           removed from the group. This behaviour can be changed via the -a option, which appends
           the user to the current supplementary group list.

(Yes)       -l, --login NEW_LOGIN
           The name of the user will be changed from LOGIN to NEW_LOGIN. Nothing else is changed. In
           particular, the user's home directory or mail spool should probably be renamed manually
           to reflect the new login name.

(no -> passwd -l)       -L, --lock
           Lock a user's password. This puts a '!' in front of the encrypted password, effectively
           disabling the password. You can't use this option with -p or -U.

           Note: if you wish to lock the account (not only access with a password), you should also
           set the EXPIRE_DATE to 1.

(yes if with -l)       -m, --move-home
           Move the content of the user's home directory to the new location.

           This option is only valid in combination with the -d (or --home) option.

           usermod will try to adapt the ownership of the files and to copy the modes, ACL and
           extended attributes, but manual changes might be needed afterwards.

(Don't know)       -o, --non-unique
           When used with the -u option, this option allows to change the user ID to a non-unique
           value.

 (No -> passwd)      -p, --password PASSWORD
           The encrypted password, as returned by crypt(3).

           Note: This option is not recommended because the password (or encrypted password) will be
           visible by users listing the processes.

           The password will be written in the local /etc/passwd or /etc/shadow file. This might
           differ from the password database configured in your PAM configuration.

           You should make sure the password respects the system's password policy.

(Don't know)      -R, --root CHROOT_DIR
           Apply changes in the CHROOT_DIR directory and use the configuration files from the
           CHROOT_DIR directory.

(yes)       -s, --shell SHELL
           The name of the user's new login shell. Setting this field to blank causes the system to
           select the default login shell.

(Don't know, but better to use adduser for checking  UID_MIN, UID_MAX, SYS_UID_MIN, SYS_UID_MAX
and problematic for existing file ownership) 
        -u, --uid UID
           The new numerical value of the user's ID.

           This value must be unique, unless the -o option is used. The value must be non-negative.

           The user's mailbox, and any files which the user owns and which are located in the user's
           home directory will have the file user ID changed automatically.

           The ownership of files outside of the user's home directory must be fixed manually.

           No checks will be performed with regard to the UID_MIN, UID_MAX, SYS_UID_MIN, or
           SYS_UID_MAX from /etc/login.defs.

(no -> passwd -u)        -U, --unlock
           Unlock a user's password. This removes the '!' in front of the encrypted password. You
           can't use this option with -p or -L.

           Note: if you wish to unlock the account (not only access with a password), you should
           also set the EXPIRE_DATE (for example to 99999, or to the EXPIRE value from
           /etc/default/useradd).

(if -l and SELINUX enabled I suppose this is needed)       -Z, --selinux-user SEUSER
           The new SELinux user for the user's login.

           A blank SEUSER will remove the SELinux user mapping for user LOGIN (if any).

So in my opinion for a applet that doesn't duplicate existing funcionality
I would implement:

usermod -l  (-Z if SELINUX)  -d (-m if -d enabled) -s

Just my 2 cents,

Ciao,
Tito
> >> >> Alternatively, I have to look into the get/setpwent syscalls?
> >> >
> >> > Yes.  You can take a look at libbb/update_passwd.c for inspiration
> >> > and you need to be root to perform the user name change.
> >>
> >> It does not seem to use setpwent/getpwent though. It seems to be
> >> fiddling with manual file opening and so on. Why is it like that?
> >
> > I think editing on a per line basis is easier in that you can simply
> > write the untouched lines to the new file and edit the field
> > of the line of interest without touching other fields.
> 
> Fair enough, albeit there could have been a serialization posix method
> out of the passwd structure creating the string for convenience...
> 
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic