[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: [PATCH] ifup: ifdown for network interface with mapped configuration
From: "Matthias Loy" <matthias.loy () hbm ! com>
Date: 2014-03-27 11:44:28
Message-ID: 53340F1C.8040905 () hbm ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hello,
back in late 2012 I posted a little patch concerning shutting down
interfaces with mapped configuration. Unfortunately it hasn't been
integrated into the busybox sources.
I would like to make a second try and send you a patch to your git
repository.
kind regards,
Matthias Loy
-------- Original-Nachricht --------
Betreff: [PATCH] ifup: ifdown for network interface with mapped
configuration
Datum: Sun, 25 Nov 2012 20:49:00 +0100
Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | \
www.hbm.com
Registered as GmbH (German limited liability corporation) in the commercial register \
at the local court of Darmstadt, HRB 1147 Company domiciled in Darmstadt | CEO: \
Andreas Huellhorst | Chairman of the board: James Charles Webster
Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des \
Amtsgerichts Darmstadt unter HRB 1147 Sitz der Gesellschaft: Darmstadt | \
Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles \
Webster
The information in this email is confidential. It is intended solely for the \
addressee. If you are not the intended recipient, please let me know and delete this \
email.
Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den \
Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren \
Sie mich bitte kurz und loeschen diese E-Mail.
Von: Matthias Loy <matthias.loy@hbm.com>
An: <busybox@busybox.net>
Hello,
we are using ifup from busy box in our embedded devices. In order to
reconfigure network interfaces we call ifdown, change the configuration
files and call ifup again. We found that ifdown does not work on mapped
configurations like eth1-dhcp or dhcp-manual. ifup is working fine.
Attached you find a small patch solving our problem. Is this ok for you?
regards,
Matthias Loy
[Attachment #5 (text/html)]
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
back in late 2012 I posted a little patch concerning shutting down
interfaces with mapped configuration. Unfortunately it hasn't been
integrated into the busybox sources.<br>
I would like to make a second try and send you a patch to your git
repository.<br>
<br>
kind regards,<br>
Matthias Loy<br>
<div class="moz-forward-container"><br>
-------- Original-Nachricht --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Betreff:
</th>
<td>[PATCH] ifup: ifdown for network interface with mapped
configuration</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Datum: </th>
<td>Sun, 25 Nov 2012 20:49:00 +0100</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE"><br>
<p style="FONT-SIZE: 8pt; COLOR: black; FONT-FAMILY:Arial,Helvetica,sans-serif">
<br><br>
Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | \
www.hbm.com <br /><br /> Registered as GmbH (German limited liability corporation) \
in the commercial register at the local court of Darmstadt, HRB 1147 <br /> \
Company domiciled in Darmstadt | CEO: Andreas Hüllhorst | Chairman of the board: \
James Charles Webster <br />
<br />
Als Gesellschaft mit beschränkter Haftung eingetragen im Handelsregister des \
Amtsgerichts Darmstadt unter HRB 1147 <br /> Sitz der Gesellschaft: Darmstadt | \
Geschäftsführung: Andreas Hüllhorst | Aufsichtsratsvorsitzender: James \
Charles Webster <br />
<br />
The information in this email is confidential. It is intended solely for the \
addressee. If you are not the intended recipient, please let me know and delete this \
email. <br />
<br />
Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für \
den Empfänger bestimmt. Sollten Sie nicht der eigentliche Empfänger sein, \
informieren Sie mich bitte kurz und löschen diese E-Mail.</p> <br>Von: </th>
<td>Matthias Loy <a class="moz-txt-link-rfc2396E" \
href="mailto:matthias.loy@hbm.com"><matthias.loy@hbm.com></a></td> </tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">An: </th>
<td><a class="moz-txt-link-rfc2396E" \
href="mailto:busybox@busybox.net"><busybox@busybox.net></a></td> </tr>
</tbody>
</table>
<br>
<br>
<pre>Hello,
we are using ifup from busy box in our embedded devices. In order to
reconfigure network interfaces we call ifdown, change the configuration
files and call ifup again. We found that ifdown does not work on mapped
configurations like eth1-dhcp or dhcp-manual. ifup is working fine.
Attached you find a small patch solving our problem. Is this ok for you?
regards,
Matthias Loy
</pre>
<br>
</div>
<br>
</body>
</html>
["0001-mapped-interface-should-be-resolved-in-case-of-ifdow.patch" (text/x-patch)]
From df4125f7dcd738eae0bebc4a02efcce9f223a88d Mon Sep 17 00:00:00 2001
From: Matthias Loy <matthias.loy@hbm.com>
Date: Sun, 25 Nov 2012 20:22:36 +0100
Subject: [PATCH] mapped interface should be resolved in case of ifdown
---
networking/ifupdown.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/networking/ifupdown.c b/networking/ifupdown.c
index 8180482..6637eee 100644
--- a/networking/ifupdown.c
+++ b/networking/ifupdown.c
@@ -1252,7 +1252,7 @@ int ifupdown_main(int argc UNUSED_PARAM, char **argv)
}
#if ENABLE_FEATURE_IFUPDOWN_MAPPING
- if ((cmds == iface_up) && !NO_MAPPINGS) {
+ if (!NO_MAPPINGS) {
struct mapping_defn_t *currmap;
for (currmap = defn->mappings; currmap; currmap = currmap->next) {
--
1.7.10.4
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic