[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH v2] Ntpd config file support
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2014-03-25 12:36:26
Message-ID: CAK1hOcOhZ_tBwXrZtzRCr0EE0iTkuGGdw7Un8xWw_c0Ck7a4fQ () mail ! gmail ! com
[Download RAW message or body]

On Mon, Mar 24, 2014 at 2:15 AM, Harald Becker <ralda@gmx.de> wrote:
>>+                      bb_error_msg("skipping %s:%u:
>>unimplemented command '%s'",
>>+                              "/etc/ntp.conf",
>>parser->lineno, token[0]
>>+                      );
>
> Bad idea to do this! The default ntpd.conf contains other options
> than just server lines. All those lines will now produce
> "skipping" messages on startup. Multiple messages on any startup,
> probably. Most users will wonder what has gone wrong and look for
> something suspicious, and will ask why BB throws those errors.

They _should_ wonder. If they have other lines there,
they probably expect them to have some effect.

> IMO not so good to simply get compatibility. With those messages
> nobody can really use the default ntpd.conf for BB without
> modifications. Your intention?

My thinking is that users need to know that their ntpd
ignored some instructions.

> ... *AND* I'm still insisting in having this config file code not
> included in standard build binaries. As others also stated we do
> not need this feature (examples have bean given)

Logically, you should be objecting to a few dozens of other "default y"
config options since "we don't need them" too.

What rules do you propose to be used in deciding which option should
default to "y" or "n"?
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]