[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: udhcpc: dont use BPF filter, users report problems (bugs 4598, 6746), commit e4785ca653d0e219926
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2014-02-20 11:27:16
Message-ID: CAK1hOcNBZmM78JtNo4MjNDxfGKqHzqvPEszoDsq5XU6SE=5Ebw () mail ! gmail ! com
[Download RAW message or body]

Yes.
Because I am not convinced we need it enabled.

On Wed, Feb 19, 2014 at 11:27 PM, Vladislav Grishenko <themiron@mail.ru> wrote:
> Hi Denys,
> Thanks, but filter code is still disabled
>
> diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c
> --- a/networking/udhcp/dhcpc.c
> +++ b/networking/udhcp/dhcpc.c
> @@ -990,7 +990,6 @@ static int udhcp_raw_socket(int ifindex)
>         sock.sll_ifindex = ifindex;
>         xbind(fd, (struct sockaddr *) &sock, sizeof(sock));
>
> -#if 0 /* Several users reported breakage when BPF filter is used */
>         if (CLIENT_PORT == 68) {
>                 /* Use only if standard port is in use */
>                 /*
> @@ -1041,7 +1040,6 @@ static int udhcp_raw_socket(int ifindex)
>                                 sizeof(filter_prog)) >= 0)
>                         log1("Attached filter to raw socket fd"); // log?
>         }
> -#endif
>
>         if (setsockopt(fd, SOL_PACKET, PACKET_AUXDATA,
>                         &const_int_1, sizeof(int)) < 0
> --
> 1.7.2.5
>
> Best Regards, Vladislav Grishenko
>
>
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]