[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] testsuite: fix last "which" change
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2014-01-23 13:42:32
Message-ID: CAK1hOcO3KODp_tPQX72=D94VGFy1TUd7kzWrRMWgwW9vf52-WA () mail ! gmail ! com
[Download RAW message or body]

Applied, thanks!

On Sun, Jan 19, 2014 at 4:30 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> In commit afa63b2dcdc9b9 I replaced `type -p' with
> `command -pv'.  But actually it is wrong, the right
> substitution is `command -v'.  We need to find our
> busybox which is in the first directory in $PATH, so
> `command -p' should not be used because it uses
> default PATH, not current value of PATH where our
> busybox binary resides.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  testsuite/which/which-uses-default-path |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testsuite/which/which-uses-default-path b/testsuite/which/which-uses-default-path
> index 349583d..92b6018 100644
> --- a/testsuite/which/which-uses-default-path
> +++ b/testsuite/which/which-uses-default-path
> @@ -1,4 +1,4 @@
> -BUSYBOX=$(command -pv busybox)
> +BUSYBOX=$(command -v busybox)
>  SAVED_PATH=$PATH
>  unset PATH
>  $BUSYBOX which ls
> --
> 1.7.10.4
>
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]