[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: dumpkmap/loadkmap misses handling of K_ALLOCATED and K_NOSUCHMAP
From:       John Spencer <maillist-busybox () barfooze ! de>
Date:       2013-09-20 18:57:28
Message-ID: 523C9A98.9060808 () barfooze ! de
[Download RAW message or body]

On 09/19/2013 05:55 PM, Denys Vlasenko wrote:
>
> Maybe just a comment will do?
>
>                          /*
>                           * Note: table[idx:0] can contain special value
>                           * K_ALLOCATED (marks allocated tables in kernel).
>                           * dumpkmap saves the value as-is; but attempts
>                           * to load it here fail, since it isn't a valid
>                           * key value: it is K(KT_SPEC,126) == 2<<8 + 126,
>                           * whereas last valid KT_SPEC is
>                           * K_BARENUMLOCK == K(KT_SPEC,19).
>                           * So far we just ignore these errors:
>                           */
>                          ioctl(fd, KDSKBENT,&ke);
>

yes, that helps. thanks for applying this.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]