[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH alternative] swapon: adhere swap priority in fstab
From:       Tito <farmatito () tiscali ! it>
Date:       2013-08-08 11:59:54
Message-ID: 201308081359.54996.farmatito () tiscali ! it
[Download RAW message or body]

On Thursday 08 August 2013 10:19:10 you wrote:
> On Mon, Aug 5, 2013 at 1:36 AM, Tito <farmatito@tiscali.it> wrote:
> > BTW: Denys, due to my limited understanding of  this complex issues i wonder why
> >          we handle 1111xxxx as an ERANGE error in bb_strtonum.c
> 
> Because it's useful to differentiate strings like
> "NNN ...", "NNN,....", "NNN)...", "NNN\n" etc which are often valid
> when you parse a line with many elements,
> from "NNNNfoo" where foo are letters - these are almost always
> clearly bogus.
> 

Yes, I just was surprised that real swapon handled the corner case
pri=1somechars parsing it to pri=1 while our bb_strtoXXX functions
just errored out rather than returning the number so far decoded
as strtol does.
If this is the intended behaviour it is fine for me.

Ciao,
Tito
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]