[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH 4/4] volume_id: add f2fs detection
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2013-08-01 9:08:21
Message-ID: CAK1hOcO4LoDaFvUKViBZmWk6BHH5W2eXBHpfN8MqMY05Pgwo6Q () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jun 28, 2013 at 10:52 AM, Sven-Göran Bergh
<svengbergh-busybox@yahoo.com> wrote:
> volume_id: add f2fs detection
> 
> function                                             old     new   delta
> volume_id_probe_f2fs                                   -      98     +98
> 
> Signed-off-by: Sven-Göran Bergh <sgb@systemasis.org>
> ---
> util-linux/volume_id/f2fs.c               |   95 \
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ \
> util-linux/volume_id/volume_id.c          |    3 +++ \
> util-linux/volume_id/volume_id_internal.h |    2 ++ 3 files changed, 100 \
> insertions(+) 
> Patch attached.

+       if (le16_to_cpu(sb->major_ver) == 1 && le16_to_cpu(sb->minor_ver) == 0)
+               return 0;

It's better to perform endian conversion on the constant,
compiler can do it at compile time.

Applied, thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]