[prev in list] [next in list] [prev in thread] [next in thread]
List: busybox
Subject: Re: [PATCH] Refactor catv. Move visible from stty to libbb.
From: Denys Vlasenko <vda.linux () googlemail ! com>
Date: 2013-07-30 4:31:27
Message-ID: 201307300631.27800.vda.linux () googlemail ! com
[Download RAW message or body]
On Friday 26 July 2013 18:30, Bernhard Reutner-Fischer wrote:
> On 9 July 2013 20:58, Bartosz Go=B3aszewski <bartekgola@gmail.com> wrote:
> > 2013/7/9 Bartosz Go=B3aszewski <bartekgola@gmail.com>:
> >> 2013/7/9 Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>:
> >>> On 9 July 2013 20:22, Bartosz Golaszewski <bartekgola@gmail.com> wrot=
e:
> >>>> Fixes the following TODO:
> >>>>
> >>>> stty's visible() function and catv's guts are identical. Merge the=
m into
> >>>> an appropriate libbb function.
> >>>>
> >>>> Also makes catv behave exactly like coreutils' cat -v e.g. it'll pri=
nt 'M-^I'
> >>>> instead of 'M- '.
> >>>
> >>> Awesome. bloat-o-meter output, please?
> >>> thanks,
> =
> > ./scripts/bloat-o-meter ./busybox.old ./busybox.new
> > function old new delta
> > .rodata 140405 140177 -228
> > -----------------------------------------------------------------------=
-------
> > (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-228) Total: -22=
8 bytes
> =
> LGTM.
bloat-o-meter looks wrong. It should show something like
function old new delta
visible - 70 +70
do_display 431 379 -52
catv_main 306 250 -56
---------------------------------------------------------------------------=
---
(add/remove: 1/0 grow/shrink: 0/2 up/down: 70/-108) Total: -38 by=
tes
Applied with significant tweaking. Thanks.
-- =
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic