[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: Patch for udhcpc hwtype
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2013-05-17 13:29:09
Message-ID: CAK1hOcP8KVdkkQZ0UV639TGV1j6BHof-=ckgQdWEdcqZbGktkg () mail ! gmail ! com
[Download RAW message or body]

On Wed, May 8, 2013 at 11:11 AM, Sam Liddicott <sam@liddicott.com> wrote:
> However I still question if this fix should also have been applied further
> down the function; the line:
>
>                         memcpy(existing->data + OPT_DATA + old_len, buffer,
> length);
>
> possibly should also be
>
>                         memcpy(existing->data + OPT_DATA + old_len,
> allocated ? allocated : buffer, length);

Yes, looks like it should be.
Fixed in git.
Thanks!
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]