[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    RE: [PATCH] volume_id: add f2fs detection
From:       Sven-Göran Bergh <svengbergh-busybox () yahoo ! com>
Date:       2013-01-14 13:08:58
Message-ID: 1358168938.95404.YahooMailNeo () web121801 ! mail ! ne1 ! yahoo ! com
[Download RAW message or body]



2013-01-14 02:32, Denys Vlasenko <vda.linux@googlemail.com>:

> 
> On Sunday 13 January 2013 18:19, Sven-Göran Bergh wrote:
>>  This patch adds the emerging f2fs as a recognized
>>  filesystem by blkid.
> 
> 
> f2fs: introduce flash-friendly file system
> From:          김재극 <jaegeuk.kim@samsung.com>
> Subject:          [PATCH 00/16] f2fs: introduce flash-friendly file system
> Date:          Fri, 05 Oct 2012 20:55:07 +0900
> 
> ^^^^^^^^^^^^^^^^^
> It is a little bit too emerging at the moment :)
> 
> Let's wait a few months to see where it is going, is it well received etc?

It is currently included in kernel 3.8.rc3, but I see your point.

> The patch per se looks good.
> 
> Please use "new-style" kbuild integration: instead of this line
> in util-linux/volume_id/Kbuild.src:
> 
> lib-$(CONFIG_FEATURE_VOLUMEID_F2FS)             += f2fs.o
> 
> use a
> 
> //kbuild:lib-$(CONFIG_FEATURE_VOLUMEID_F2FS) += f2fs.o
> 
> line in util-linux/volume_id/f2fs.c

That looks neat! (I have to read up on the new kbuild style)
I will re-post a revised patch in say 2 months.

Thanks
/S-G

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]