[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] CONFIG_PID_FILE_PATH: new configuration option for pidfile paths
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2012-12-19 20:56:34
Message-ID: 201212191556.35706.vapier () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 10 December 2012 20:25:46 Mike Frysinger wrote:
> On Monday 10 December 2012 14:49:39 Anthony G. Basile wrote:
> > --- a/miscutils/watchdog.c
> > +++ b/miscutils/watchdog.c
> > 
> > +	remove_pidfile(CONFIG_PID_FILE_PATH"/watchdog.pid");
> 
> stylewise, there should be a space before the first "
> 
> i wonder if we should add a helper that takes a name and it takes care of
> putting that in via "/var/run/%.pid"
> 
> if there are no complaints, i'll merge this in a bit

puuuuuuuuuuuuuuuuuuuuushed w/that style issue fixed
-mike

["signature.asc" (application/pgp-signature)]

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]